dMZX Forums: Player movement key repeat timer is reset when the player is locked -> Archived MegaZeux Bugs -> Tracker

The player's movement uses its own key repeat timers for each direction that are independent from the normal key repeat functionality. In DOS versions, these timers were only reset when the arrow keys were pressed and released. In port versions, they are also reset when the player's movement is locked. This makes navigating the water in level 5 of Brotherhood much slower, and may affect other games more or less significantly.

Test: make a new world with the player at 0,0. Create a robot at 10,1 with this code. Test the board and hold the right arrow until the player has passed the robot significantly, then press 'Escape' without releasing the right arrow. In DOS versions, HORIZPLD and LOCAL will have the same value. In port versions, HORIZPLD will be 2 less than LOCAL.

: "l"
cycle 1
if not touching NORTH then "l"
lockplayer
wait for 5
unlockplayer
set "local" 0
: "l2"
* "&horizpld& &local&"
inc "local" 1
wait 1
goto "l2"

The code used by Brotherhood:

: "Loop"
lockplayer
wait for 3
unlockplayer
wait for 3
goto "Loop"

A possible fix might be to change lines 434-440 of game_update.c from

  else
  {
    mzx_world->key_up_delay = 0;
    mzx_world->key_down_delay = 0;
    mzx_world->key_right_delay = 0;
    mzx_world->key_left_delay = 0;
  }

to

  if(!up_pressed)
    mzx_world->key_up_delay = 0;
  if(!down_pressed)
    mzx_world->key_down_delay = 0;
  if(!right_pressed)
    mzx_world->key_right_delay = 0;
  if(!left_pressed)
    mzx_world->key_left_delay = 0;

Updating status to: Fixed
Issue fixed in: 2.92

Fixed in GIT 654a5970.

Issue fixed in: 2.91j

Moving to: Archived MegaZeux Bugs